Issue with default browser prompt not hiding resolved #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
added a commit
that referenced
this pull request
Apr 27, 2022
# By Christopher Brind (1) and others # Via GitHub * develop: Autofill scrolling fix (#538) Add web-compat code (#547) Issue with default browser prompt not hiding resolved (#550) Open Autofill settings when triggering Settings from Autofill (#534) Revert "don't draw webview background to avoid flashes (#545)" (#549) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1202041516752977/f
Description:
This PR contains a fix of default browser prompt visibility. After setting the browser as default during the onboarding, the promt on the home page remained visible
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM